Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to TF 2.1 #61

Merged
merged 9 commits into from
Apr 17, 2020
Merged

Upgrade to TF 2.1 #61

merged 9 commits into from
Apr 17, 2020

Conversation

mortendahl
Copy link
Member

@mortendahl mortendahl commented Apr 17, 2020 •
edited
Loading

Note: this removes support for all other TensorFlow versions.

TODO:

  • some tests are currently skipped since I didn't finish parameterizing them
  • build on Linux/docker is failing

@mortendahl mortendahl requested a review from jvmncs April 17, 2020 14:28
jvmncs
jvmncs reviewed Apr 17, 2020
View reviewed changes
Copy link
Member

@jvmncs jvmncs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had a few questions about dependencies! and small linting

setup.py Show resolved Hide resolved
tf_big/BUILD Outdated Show resolved Hide resolved
tf_big/python/ops/big_ops_test.py Outdated Show resolved Hide resolved
tf_big/python/ops/big_ops_test.py Outdated Show resolved Hide resolved
@mortendahl mortendahl changed the title Upgrade to TF 2.1 [don't merge] Upgrade to TF 2.1 Apr 17, 2020
@mortendahl mortendahl requested a review from jvmncs April 17, 2020 17:23
@mortendahl mortendahl changed the title [don't merge] Upgrade to TF 2.1 Upgrade to TF 2.1 Apr 17, 2020
@mortendahl
Copy link
Member Author

Created #63 for remaining linux build. Merging this guy to get started on shapes.

@mortendahl mortendahl merged commit 0df074c into master Apr 17, 2020
@mortendahl mortendahl deleted the tf2 branch April 17, 2020 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvmncs jvmncs jvmncs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mortendahl @jvmncs